-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os: set the correct op while returning errors from WriteAt, ReadFrom, ReadAt #45376
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 16fa368) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/307170 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Emmanuel Odeke: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Go Bot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=fc751ecc Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Go Bot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Nidhi Doshi: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Nidhi Doshi: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/307170. |
For some of the errors returned from WriteAt, ReadFrom, ReadAt the op set
in PathError does not correctly match the name of the operation.
For eg. the op is set to "write" in ReadFrom.
This change fixes the ops to match the name of the function they
correspond to.