x/telemetry/crashmonitor: fixup inaccurate locations in sigpanic stacks

[findleyr]

As described in #70637 (comment), the current behavior of crash output isn't quite correct for usage with runtime.CallersFrames: for runtime.sigpanic frames, we need to increment the PC of the next frame to get the correct location.

This issue tracks implementing this workaround in x/telemetry/crashmonitor.

In the future, we hope that debug.SetCrashOutput will support structured output, so that we can remove this fix.

[gabyhelp]

Related Issues

• runtime: panic crash should not show top panic frame #17901 (closed)

Related Code Changes

• runtime, runtime/pprof: add Frames to get file/line for Callers
• runtime: avoid bad unwinding from sigpanic in C code

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

Assigning this to @prattmic, since he already (graciously) did the work.

[prattmic]

Ah! I didn't realize there was an issue for this. I think this is effectively done now with https://go.dev/cl/637755, though I suppose you'll need to bump the version of x/telemetry in x/tools/gopls.

[findleyr]

Thanks, I'll close this with the x/telemetry import. Leaving it to track that work.

[gopherbot]

Change https://go.dev/cl/639715 mentions this issue: gopls: update telemetry dependency for crashmonitor fix