Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: "not found" SemanticTokens bug (via telemetry) #68205

Closed
adonovan opened this issue Jun 26, 2024 · 40 comments
Closed

x/tools/gopls: "not found" SemanticTokens bug (via telemetry) #68205

adonovan opened this issue Jun 26, 2024 · 40 comments
Assignees
@adonovan
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@adonovan
Copy link
Member

adonovan commented Jun 26, 2024 •
edited
Loading 

#!stacks
"bug.Report" && "golang.(*tokenVisitor).errorf:+2" && "(*tokenVisitor).findKeyword:+10"

Issue created by stacks.

This stack aczPmA was reported by telemetry:

	//(in unparsable programs: type _ <-<-chan int)
	tv.errorf("not found:%s %v", keyword, safetoken.StartPosition(tv.fset, start))
	return token.NoPos
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+24
go/ast.Walk:+35
go/ast.Walk:+125
go/ast.Walk:+305
go/ast.Inspect:=397
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).visit:+12
golang.org/x/tools/gopls/internal/golang.SemanticTokens:+42
golang.org/x/tools/gopls/internal/server.(*server).semanticTokens:+15
golang.org/x/tools/gopls/internal/server.(*server).SemanticTokensFull:+1

golang.org/x/tools/gopls@v0.16.0-pre.2 go1.22.0 linux/amd64 vscode-insiders (1)

Dups: 9Zm4MQ R3WOZQ 4aaPlw ZDZBcQ YtGIsA DoRoLA KWhiSQ rpL8iQ sBXcwA jdtSRw HVP7dQ Mh0muw Qu7Tdw 4MvswQ KEMm6A PKFjJw 786C2g MDUmEw iGqw0w EtWi_A AAHxwg iAZ-4A S2WfMQ zHVLeQ h-YqOQ kCXrCQ 7yumQA AZLRvA wiVT3g 0Tywlg YCKLFw QWK8Cg d9Bf4A qj_Yjg MUD2UA HkMXKg gkS4vQ YEDdDw G-n56g F0SOfA qz_-iQ XSDNDw FePSlg xQsXAQ eaDyXA HUMVuQ
@adonovan adonovan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels Jun 26, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 26, 2024
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@adonovan adonovan self-assigned this Jun 26, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/595117 mentions this issue: gopls/internal/golang: don't panic when findKeyword fails

@adonovan
Copy link
Member Author

adonovan commented Jul 9, 2024

This stack 9Zm4MQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+24
go/ast.Walk:+35
go/ast.Walk:+128
go/ast.Walk:+24
go/ast.Walk:+35
go/ast.Walk:+132
go/ast.Walk:+281
go/ast.Walk:+294
go/ast.Inspect:=397

golang.org/x/tools/gopls@v0.16.1 go1.22.0 linux/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

adonovan commented Jul 9, 2024

This stack R3WOZQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+266
go/ast.Walk:+294
go/ast.Inspect:=397
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).visit:+12
golang.org/x/tools/gopls/internal/golang.SemanticTokens:+42
golang.org/x/tools/gopls/internal/server.(*server).semanticTokens:+15
golang.org/x/tools/gopls/internal/server.(*server).SemanticTokensFull:+1
golang.org/x/tools/gopls/internal/protocol.serverDispatch:+511
golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5

golang.org/x/tools/gopls@v0.16.0 go1.22.4 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

This stack 4aaPlw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+24
go/ast.Walk:+35
go/ast.Walk:+128
go/ast.Walk:+305
go/ast.Inspect:=397
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).visit:+12
golang.org/x/tools/gopls/internal/golang.SemanticTokens:+42
golang.org/x/tools/gopls/internal/server.(*server).semanticTokens:+15
golang.org/x/tools/gopls/internal/server.(*server).SemanticTokensFull:+1

golang.org/x/tools/gopls@v0.16.1 go1.22.4 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

adonovan commented Aug 5, 2024

This stack ZDZBcQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+266
go/ast.Walk:+294
go/ast.Walk:+146
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+245
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307

golang.org/x/tools/gopls@v0.16.1 go1.22.5 windows/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@findleyr
Copy link
Member

findleyr commented Aug 6, 2024

This stack YtGIsA was reported by telemetry:

gopls/bug                                                                                                                                                                     golang.org/x/tools/gopls/internal/util/bug.report:+35                                                                                                                         
golang.org/x/tools/gopls/internal/util/bug.Report:=68                                                                                                                         golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2                     
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10                                                                                                      golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52                                                                                                          
go/ast.inspector.Visit:+1                                                                                                                                                     
go/ast.Walk:+1                                                                                                                                                                
go/ast.Walk:+71                                                                        
go/ast.Walk:+136                           
go/ast.Walk:+266                           
go/ast.Walk:+294                           
go/ast.Walk:+146                           
go/ast.walkStmtList:=32
go/ast.Walk:+184                           
go/ast.Walk:+307                           
go/ast.Inspect:=397                        

golang.org/x/tools/gopls@v0.16.0 go1.22.4 darwin/arm64 neovim (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

This stack DoRoLA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+109
go/ast.Walk:+150
go/ast.walkList[...]:=21
go/ast.Walk:+178
go/ast.Walk:+187
go/ast.walkList[...]:=21
go/ast.Walk:+214
go/ast.walkList[...]:=21
go/ast.Walk:+178

golang.org/x/tools/gopls@v0.16.1 go1.23rc2 darwin/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

adonovan commented Sep 3, 2024

This stack rpL8iQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+24
go/ast.Walk:+35
go/ast.Walk:+118
go/ast.Walk:+281
go/ast.Walk:+294
go/ast.Inspect:=397
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).visit:+12
golang.org/x/tools/gopls/internal/golang.SemanticTokens:+42
golang.org/x/tools/gopls/internal/server.(*server).semanticTokens:+15

golang.org/x/tools/gopls@v0.16.2-pre.1 go1.22.5 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

adonovan commented Sep 3, 2024

This stack sBXcwA was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+24
go/ast.Walk:+35
go/ast.Walk:+125
go/ast.Walk:+93
go/ast.Walk:+170
go/ast.walkStmtList:=32
go/ast.Walk:+184
go/ast.Walk:+307
go/ast.Inspect:=397

golang.org/x/tools/gopls@v0.16.1 go1.22.4 windows/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

adonovan commented Sep 3, 2024

This stack KWhiSQ was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+22
go/ast.walkList[...]:=21
go/ast.Walk:+32
go/ast.Walk:+112
go/ast.Walk:+275
go/ast.walkList[...]:=21
go/ast.Walk:+287
go/ast.Inspect:=372
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).visit:+12

golang.org/x/tools/gopls@v0.16.1 go1.23.0 linux/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

adonovan commented Sep 6, 2024

This stack jdtSRw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Report:=68
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).errorf:+2
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).findKeyword:+10
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).inspect:+52
go/ast.inspector.Visit:+1
go/ast.Walk:+1
go/ast.Walk:+71
go/ast.Walk:+139
go/ast.Walk:+24
go/ast.Walk:+35
go/ast.Walk:+125
go/ast.Walk:+305
go/ast.Inspect:=397
golang.org/x/tools/gopls/internal/golang.(*tokenVisitor).visit:+12
golang.org/x/tools/gopls/internal/golang.SemanticTokens:+42

golang.org/x/tools/gopls@v0.16.1 go1.22.2 windows/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

This stack HVP7dQ was reported by telemetry:

gopls/bug

golang.org/x/tools/gopls@v0.16.2 go1.23.0 windows/amd64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

This stack Mh0muw was reported by telemetry:

gopls/bug

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan
Copy link
Member Author

This stack Qu7Tdw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

This stack 4MvswQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (1)

This stack KEMm6A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack PKFjJw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.3 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

This stack 786C2g was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.3 linux/amd64 vscode (1)

This stack MDUmEw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack iGqw0w was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

This stack EtWi_A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 other,vscode (1)

@adonovan
Copy link
Member Author

adonovan commented Oct 1, 2024

This stack AAHxwg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

adonovan commented Oct 7, 2024

This stack iAZ-4A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

adonovan commented Oct 8, 2024

This stack S2WfMQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack zHVLeQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 darwin/arm64 other,vscode (1)

This stack h-YqOQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 linux/amd64 other (1)

@adonovan
Copy link
Member Author

This stack kCXrCQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/amd64 other,vscode (1)

@adonovan
Copy link
Member Author

This stack 7yumQA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack AZLRvA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.5 linux/amd64 vscode (1)

This stack wiVT3g was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 other (1)

@adonovan
Copy link
Member Author

This stack 0Tywlg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.5 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack YCKLFw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.1 darwin/arm64 vscode-insiders (1)

This stack QWK8Cg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 vscode (1)

This stack d9Bf4A was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack qj_Yjg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

adonovan commented Nov 4, 2024

This stack MUD2UA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

adonovan commented Nov 6, 2024

This stack HkMXKg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

adonovan commented Nov 7, 2024

This stack gkS4vQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack YEDdDw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.0 darwin/arm64 other,vscode (1)

@adonovan
Copy link
Member Author

This stack G-n56g was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.5 linux/amd64 other,vscode (1)

@adonovan
Copy link
Member Author

This stack F0SOfA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.22.0 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

adonovan commented Dec 9, 2024

This stack qz_-iQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/arm64 vscode (1)

@adonovan
Copy link
Member Author

This stack XSDNDw was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.3 linux/amd64 vscode (1)

@adonovan
Copy link
Member Author

This stack FePSlg was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 linux/amd64 vscode (1)

This stack xQsXAQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.3 darwin/arm64 neovim,other (1)

This stack eaDyXA was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.1 darwin/amd64 vscode (1)

@adonovan
Copy link
Member Author

This stack HUMVuQ was reported by telemetry:

golang.org/x/tools/gopls@v0.16.2 go1.23.2 darwin/arm64 vscode (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@adonovan @gopherbot @findleyr @gabyhelp