Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/mod_get_direct fails with "Filename too long" on Windows [1.20 backport] #63988

Closed
heschi opened this issue Nov 7, 2023 · 2 comments
Closed

cmd/go: TestScript/mod_get_direct fails with "Filename too long" on Windows [1.20 backport] #63988

heschi opened this issue Nov 7, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.20.12

Comments

@heschi
Copy link
Contributor

heschi commented Nov 7, 2023

During presubmit testing on https://go.dev/cl/540516 during the latest minor releases, http://ci.chromium.org/b/8765065906911361985 failed:

error: cannot lock ref 'refs/remotes/origin/release-please--branches--main--components--accesscontextmanager': Unable to create 'C:/b/s/w/ir/x/t/cmd-go-test-1941989685/tmpdir1769739975/mod_get_direct1216447303/gopath/pkg/mod/cache/vcs/8ce8c8474615d5c812f8c00ea4d3d17e65a044e13e4ded714ba67b0d574d973b/./refs/remotes/origin/release-please--branches--main--components--accesscontextmanager.lock': Filename too long

@bcmills fixed this in https://go.dev/cl/482819. Let's backport to 1.20. cc @golang/release
@heschi heschi added the CherryPickCandidate Used during the release process for point releases label Nov 7, 2023
@heschi heschi added this to the Go1.20.12 milestone Nov 7, 2023
@dmitshur dmitshur added the GoCommand cmd/go label Nov 7, 2023
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Nov 7, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 7, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/539278 mentions this issue: [release-branch.go1.20] cmd/go/internal/modfetch/codehost: set core.longpaths in Git repos on Windows

@gopherbot
Copy link
Contributor

Closed by merging e1dc209 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Nov 7, 2023
@heschi
[release-branch.go1.20] cmd/go/internal/modfetch/codehost: set core.l…
e1dc209 
…ongpaths in Git repos on Windows

This setting appears to be needed to avoid “Filename too long” errors
when downloading modules from repos with long branch names,
particularly if the path to the module cache is already fairly long
(as may be the case in CI systems and in tests of cmd/go itself).

Fixes #63988.

Change-Id: I3aa89ea872b29eb0460c8a8afc94f182a68982fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/482819
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 0c89487)
Reviewed-on: https://go-review.googlesource.com/c/go/+/539278
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@golang golang locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.20.12
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @heschi