Skip to content

net/http: add test coverage for Fetch API-based Transport when viable #60810

Open
@dmitshur

Description

@dmitshur

In #57613 (comment), I wrote:

[...] the main reason the fake socket path was used is because that was the easiest path forward at the time. Back then, the NaCL port had the fake socket code implemented, and Node didn't support fetch. By now, with NaCL port being long gone and Node supporting fetch, it might be net simpler to start using fetch. But that is fine to investigate and consider doing if desired later.

Just disabling fetch during tests with Node 18 as done in CL 463976 is good to resolve the immediate issue. Thanks.

Now that the immediate issue is resolved, this is the tracking issue for the "investigate and consider doing" part.

In addition to possibly being simpler, I think the main benefit here would be if it lets us have coverage for the Fetch API-based Transport on the builders, and help catch regressions like:

CC @golang/js, @golang/wasm.

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.OS-JSSuggestedIssues that may be good for new contributors looking for work to do.TestingAn issue that has been verified to require only test changes, not just a test failure.arch-wasmWebAssembly issues

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions