Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: decide on a default value for "symbolScope" #60494

Open
findleyr opened this issue May 29, 2023 · 0 comments
Open

x/tools/gopls: decide on a default value for "symbolScope" #60494

findleyr opened this issue May 29, 2023 · 0 comments
Labels
gopls/telemetry issues that would benefit from telemetry data gopls Issues related to the Go language server, gopls. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.18.0

Comments

@findleyr
Copy link
Contributor

Following up on #37236, we need to decide on the default value for the new symbolScope setting.

I personally like seeing symbols from dependencies (as in the "all" scope). Others have expressed frustration with this behavior, and only want to see results for modules contained in the workspace (as in the "workspace") scope.

We should choose the default that more users prefer.
@findleyr findleyr added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 29, 2023
@findleyr findleyr added this to the gopls/v0.13.0 milestone May 29, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 29, 2023
@findleyr findleyr added the gopls/telemetry issues that would benefit from telemetry data label Aug 16, 2023
@findleyr findleyr modified the milestones: gopls/v0.14.0, gopls/v0.15.0 Aug 16, 2023
@findleyr findleyr modified the milestones: gopls/v0.15.0, gopls/v0.16.0 Nov 15, 2023
@findleyr findleyr modified the milestones: gopls/v0.16.0, gopls/v0.17.0 Mar 13, 2024
@findleyr findleyr modified the milestones: gopls/v0.17.0, gopls/v0.18.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls/telemetry issues that would benefit from telemetry data gopls Issues related to the Go language server, gopls. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.18.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr