Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/diagnostics: TestErrorsThatPreventAnalysis failures #58899

Closed
gopherbot opened this issue Mar 6, 2023 · 2 comments
Closed

x/tools/gopls/internal/regtest/diagnostics: TestErrorsThatPreventAnalysis failures #58899

gopherbot opened this issue Mar 6, 2023 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/diagnostics" && test == "TestErrorsThatPreventAnalysis"

Issue created automatically to collect these failures.

Example (log):

#### Start Gopls Test Logs for "TestErrorsThatPreventAnalysis/default"
[Trace - 13:25:28.939 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-427040736/TestErrorsThatPreventAnalysis/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-427040736/TestErrorsThatPreventAnalysis/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-427040736/TestErrorsThatPreventAnalysis/default/work","name":"work"}]}


[Trace - 13:25:28.939 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.6\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 13:25:28.939 PM] Sending notification 'initialized'.
...
panic: test timed out after 10m0s

testing.(*T).Run(0xc003b5b380, {0xc8bfd6, 0x7}, 0xc0073e8b90)
	/data/golang/workdir/go/src/testing/testing.go:1494 +0x46c
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc000495900, 0xc003b5b380, {0xd06684, 0x300}, 0xe045f8, {0x0, 0x0, 0x0})
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x466
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/diagnostics.TestErrorsThatPreventAnalysis(0xc003b5b380)
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/diagnostics/diagnostics_test.go:2026 +0x60
testing.tRunner(0xc003b5b380, 0xe04600)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 6, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/diagnostics" && test == "TestErrorsThatPreventAnalysis"
2023-03-06 18:12 linux-s390x-ibm tools@c91d0b88 go@0d288f90 x/tools/gopls/internal/regtest/diagnostics.TestErrorsThatPreventAnalysis (log) 
#### Start Gopls Test Logs for "TestErrorsThatPreventAnalysis/default"
[Trace - 13:25:28.939 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/data/golang/workdir/tmp/gopls-regtest-427040736/TestErrorsThatPreventAnalysis/default/gopath","GOPROXY":"file:///data/golang/workdir/tmp/gopls-regtest-427040736/TestErrorsThatPreventAnalysis/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///data/golang/workdir/tmp/gopls-regtest-427040736/TestErrorsThatPreventAnalysis/default/work","name":"work"}]}


[Trace - 13:25:28.939 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.6\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 13:25:28.939 PM] Sending notification 'initialized'.
...
panic: test timed out after 10m0s

testing.(*T).Run(0xc003b5b380, {0xc8bfd6, 0x7}, 0xc0073e8b90)
	/data/golang/workdir/go/src/testing/testing.go:1494 +0x46c
golang.org/x/tools/gopls/internal/lsp/regtest.(*Runner).Run(0xc000495900, 0xc003b5b380, {0xd06684, 0x300}, 0xe045f8, {0x0, 0x0, 0x0})
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/runner.go:169 +0x466
golang.org/x/tools/gopls/internal/lsp/regtest.Run(...)
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/diagnostics.TestErrorsThatPreventAnalysis(0xc003b5b380)
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/diagnostics/diagnostics_test.go:2026 +0x60
testing.tRunner(0xc003b5b380, 0xe04600)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 6, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2023
@bcmills
Copy link
Contributor

bcmills commented Mar 6, 2023

Duplicate of #58901

@bcmills bcmills marked this as a duplicate of #58901 Mar 6, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@bcmills bcmills removed this from Test Flakes Mar 6, 2023
@golang golang locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot