misc/wasm: incorrectly checks for require("fs") validity

[tharvik]

When loaded, wasm_exec.js tries to know on which platform it is run. "fs" is loaded if not already available and check if it is empty (when using webpack to provide an empty implementation) or not (when running inside node). The check is wrongly implemented as Object.keys returns an array of key, not a count, thus making that check always true, and unable to use with webpack.

The line in question

go/misc/wasm/wasm_exec.js

Line 31 in c4fed25

if (Object.keys(fs) !== 0) {

Which can be easily fixed by adding a .length after the Object.keys(fs).

[agnivade]

That's right. There's a CL at https://go-review.googlesource.com/c/go/+/241119.

[tharvik]

Closing as duplicate then, thanks for the pointer.

[tharvik]

Oups, missread that, reopening.

[cagedmantis]

/cc @neelance @cherrymui

[neelance]

The CL will land in the next release cycle.