-
Notifications
You must be signed in to change notification settings - Fork 1k
Commits on Jul 3, 2018
-
Remove InputsDigest, add InputImports
First steps towards a better in-sync checking system that does not rely on a merge-conflict-prone explicit hash digest.
Configuration menu - View commit details
-
Copy full SHA for c7e220d - Browse repository at this point
Copy the full SHA c7e220dView commit details -
dep: Introduce lock verification logic
This mostly supplants the hash comparison-based checking, though it's still in rough form.
Configuration menu - View commit details
-
Copy full SHA for db8b66b - Browse repository at this point
Copy the full SHA db8b66bView commit details -
gps: Convert LockedProject to an interface
This is the first step towards being able to a more expansive type - one that carries the pruning and digest information - directly within the existing Lock interface.
Configuration menu - View commit details
-
Copy full SHA for f23ef51 - Browse repository at this point
Copy the full SHA f23ef51View commit details -
gps: Introduce verify subpackage
This is a start at isolating verification logic into a discrete package. Not sure how far we'll be able to make this go without creating some import loops.
Configuration menu - View commit details
-
Copy full SHA for 81b3a3d - Browse repository at this point
Copy the full SHA 81b3a3dView commit details -
dep: Add foundation for verified, pruned vendor
THis includes changes across both dep and gps towards transparently working with vendor trees that are both configurably pruned and verifiable.
Configuration menu - View commit details
-
Copy full SHA for 485c74e - Browse repository at this point
Copy the full SHA 485c74eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cb57f5 - Browse repository at this point
Copy the full SHA 4cb57f5View commit details -
gps: Remove all reference to InputsDigest
We're now relying entirely on real validation - no more hash digest comparisons and meaningless conflicts!
Configuration menu - View commit details
-
Copy full SHA for bce4a36 - Browse repository at this point
Copy the full SHA bce4a36View commit details -
verify: Relocate lock diffing and tree hashing
Both of these subsystems make more sense in the verification package than in gps itself.
Configuration menu - View commit details
-
Copy full SHA for 0b2482d - Browse repository at this point
Copy the full SHA 0b2482dView commit details -
dep: Get DeltaWriter into a working state
This encompasses the first pass at the new, more abstracted diffing system, and the DeltaWriter implementation on top of it. Tests are needed, but cursory testing indicates that we successfully capture all types of diffs and regenerate only the subset of projects that actually need to be touched.
Configuration menu - View commit details
-
Copy full SHA for df2c26b - Browse repository at this point
Copy the full SHA df2c26bView commit details -
gps: Diff->Delta, and bitfield for change checking
Also convert the SafeWriter to use LockDelta.
Configuration menu - View commit details
-
Copy full SHA for 13ec211 - Browse repository at this point
Copy the full SHA 13ec211View commit details -
dep: Tell the user why we're solving
Add output to all of the information we assemble when checking if the Lock satisfies the current input set. Also some refactoring of the ctx.LoadProject() process to have fewer partial states.
Configuration menu - View commit details
-
Copy full SHA for 6b47f58 - Browse repository at this point
Copy the full SHA 6b47f58View commit details -
Tests are now almost completely working, after updating all the outputs to the new lock format. There is also an assortment of other fixes in here, mostly related to fixing nil pointer panics, that were uncovered by fixing up these tests.
Configuration menu - View commit details
-
Copy full SHA for f00e828 - Browse repository at this point
Copy the full SHA f00e828View commit details
Commits on Jul 4, 2018
-
gps: Collapse LockWithImports into Lock
There was no real need to delineate between Lock and LockWithImports. The old Lock had the InputsDigest concept, which was even less feasible for theoretical implementations of Lock to have, so this can't possibly be more harmful.
Configuration menu - View commit details
-
Copy full SHA for 9d4eca8 - Browse repository at this point
Copy the full SHA 9d4eca8View commit details -
dep: Make DeltaWriter sensitive to -vendor-only
Also a bunch of docs for the verify package.
Configuration menu - View commit details
-
Copy full SHA for 3c60abc - Browse repository at this point
Copy the full SHA 3c60abcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08a4349 - Browse repository at this point
Copy the full SHA 08a4349View commit details -
Configuration menu - View commit details
-
Copy full SHA for 812b8c1 - Browse repository at this point
Copy the full SHA 812b8c1View commit details
Commits on Jul 8, 2018
-
dep: Implement DeltaWriter.PrintPreparedActions()
This just abstracts and reuses the feedback already utilized by DeltaWriter.Write().
Configuration menu - View commit details
-
Copy full SHA for d22fbb8 - Browse repository at this point
Copy the full SHA d22fbb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b02ee0 - Browse repository at this point
Copy the full SHA 4b02ee0View commit details
Commits on Jul 9, 2018
-
gps/verify: Add tests for LockSatisfaction
Also better prepare it for public consumption by exporting its members, renaming some methods and improving docs.
Configuration menu - View commit details
-
Copy full SHA for 80eeec7 - Browse repository at this point
Copy the full SHA 80eeec7View commit details -
gps/verify: Add LockDiff unit tests
These should be nearly comprehensive tests for lock diffing behaviors. They follow the same functional transform table testing pattern as with the lock satisfaction tests.
Configuration menu - View commit details
-
Copy full SHA for 0db8f69 - Browse repository at this point
Copy the full SHA 0db8f69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69991c7 - Browse repository at this point
Copy the full SHA 69991c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c8a1e3 - Browse repository at this point
Copy the full SHA 5c8a1e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7a412f - Browse repository at this point
Copy the full SHA d7a412fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe299f7 - Browse repository at this point
Copy the full SHA fe299f7View commit details
Commits on Jul 10, 2018
-
dep: Encapsulate vendor verification into method
Some tests were complaining of a data race when writing to ctx.Out on a vendor verification failure. It's not clear why those tests were failing, but the complaint became a forcing function to refactor the previously-sloppy use of a channel and os.Exit(1) within a goroutine to encapsulation in a method on dep.Project.
Configuration menu - View commit details
-
Copy full SHA for a34a48d - Browse repository at this point
Copy the full SHA a34a48dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc9484a - Browse repository at this point
Copy the full SHA fc9484aView commit details