Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

go get github.com/sdboyer/gps fails because /vendor/ is not checked in #418

Closed
fabulous-gopher opened this issue Apr 21, 2017 · 3 comments
Closed

Comments

@fabulous-gopher
Copy link

From @spenczar on March 10, 2017 14:49

gps happens to require the 2.x branch of github.com/Masterminds/semver, which is not the master branch, but gps does not explicitly vendor its dependencies. That means go get github.com/sdboyer/gps (and its friends, like go test) don't work out of the box.

This took me about 30 minutes to suss out, which is a pretty significant hurdle to jumping in to help on gps/dep.

I'd be happy with loud documentation in CONTRIBUTING.md that says something like "You'll need to run glide install to populate /vendor/ before you can get started." I'd be even happier if the vendor directory were checked in, which would match what github.com/golang/dep does.

Copied from original issue: sdboyer/gps#182

@fabulous-gopher
Copy link
Author

From @sdboyer on March 10, 2017 16:26

Glad you're here! 👏 😄

Yeah, this is definitely not the best. Let's keep it simple for now, with a note in CONTRIBUTING.md. gps is going to move directly into dep soon (#300), at which point we're probably going to be developing over there, so the considerations related to vendor will be different.

@fabulous-gopher
Copy link
Author

From @spenczar on March 10, 2017 17:2

Thanks for the warm welcome! 😄

I'll write a PR to add some text to CONTRIBUTING.md, that sounds like the right plan.

@sdboyer
Copy link
Member

sdboyer commented Apr 27, 2017

(we don't need this one over in dep at all)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants