Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

dep init failed to convert github.com/boz/kail from govendor to dep #1047

Closed
dcheney-atlassian opened this issue Aug 22, 2017 · 7 comments
Closed

Comments

@dcheney-atlassian
Copy link

What version of Go (go version) and dep (git describe --tags) are you using?

% go version
go version devel +1a2ac46 Mon Aug 21 21:08:17 2017 +0000 linux/amd64

What dep command did you run?

% go get -d github.com/boz/kail
% cd $GOPATH/src/github.com/boz/tail
% govendor sync
% go build ./cmd/kail

# builds successfully

% dep init
% rm -rf vendor
% dep ensure
% go build ./cmd/kail
github.com/boz/kail/vendor/k8s.io/client-go/pkg/apis/settings
# github.com/boz/kail/vendor/k8s.io/api/core/v1
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:897:15: in.ObjectMeta.DeepCopyInto undefined (type v1.ObjectMeta has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1013:15: in.ObjectMeta.DeepCopyInto undefined (type v1.ObjectMeta has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1079:15: in.ObjectMeta.DeepCopyInto undefined (type v1.ObjectMeta has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1440:14: in.StartedAt.DeepCopyInto undefined (type v1.Time has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1457:14: in.StartedAt.DeepCopyInto undefined (type v1.Time has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1458:15: in.FinishedAt.DeepCopyInto undefined (type v1.Time has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1788:15: in.ObjectMeta.DeepCopyInto undefined (type v1.ObjectMeta has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1967:15: in.ObjectMeta.DeepCopyInto undefined (type v1.ObjectMeta has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1970:19: in.FirstTimestamp.DeepCopyInto undefined (type v1.Time has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1971:18: in.LastTimestamp.DeepCopyInto undefined (type v1.Time has no field or method DeepCopyInto)
vendor/k8s.io/api/core/v1/zz_generated.deepcopy.go:1971:18: too many errors
github.com/boz/kail/vendor/k8s.io/client-go/pkg/api/v1
github.com/boz/kail/vendor/k8s.io/client-go/pkg/apis/apps
github.com/boz/kail/vendor/k8s.io/client-go/pkg/apis/apps/v1beta1

What did you expect to see?

./kail built correctly both times.

What did you see instead?

See above, looks like dep init didn't match the exact revisions from govendor

@darkowlzz
Copy link
Collaborator

@dcheney-atlassian thanks for trying dep on an existing project, but we don't support govendor conversion yet 😞. There's a WIP PR #815 . Hopefully this issue would get solved soon 🙂.

@gianarb
Copy link

gianarb commented Dec 4, 2017

Hello @darkowlzz the PR #815 is merged. I tried the flow described above on one of my projects and it is failing for me too.

@darkowlzz
Copy link
Collaborator

@gianarb can you provide some more information about the failure? Import logs or your observations.

@sdboyer
Copy link
Member

sdboyer commented Dec 4, 2017

@gianarb actually - could you open a new issue with more details? the reasons why these conversions get things wrong can be complex and nuanced, and it's best to track each failure case separately.

wrt the original issue here, this is the error i now get:

$ go get github.com/boz/kail
$ cd $GOPATH/src/github.com/boz/kail
$ dep init -v
Getting direct dependencies...
Checked 3 directories for packages.
Found 10 direct dependencies.
Importing configuration from govendor. These are only initial constraints, and are further refined during the solve process.
Detected govendor configuration file...
  Loading /Users/sdboyer/ws/go/src/github.com/boz/kail/vendor/vendor.json
Converting from vendor.json...
init failed: unable to prepare an initial manifest and lock for the solver: Cannot determine the project root for appengine: "appengine" is not a valid import path

@carolynvs
Copy link
Collaborator

Closing as the original issue, not supporting govendor during init, has been resolved.

@gianarb The govendor config looks incorrect because it contains an invalid path "appengine". If you correct the config and init continues to fail, please open another issue and we can figure it out.

@sdboyer
Copy link
Member

sdboyer commented Dec 17, 2017

that path was, at one time, valid. I know we had special handling for appengine at one point, though I don't immediately recall how much of it remains.

@carolynvs
Copy link
Collaborator

Ah okay I didn't read past this part of the appengine doc before thinking it was bad config:

This repository supports the Go runtime on App Engine standard. It provides APIs for interacting with App Engine services. Its canonical import path is google.golang.org/appengine.

Further down they provide instructions to get off their legacy appengine import style:

https://github.com/golang/appengine#updating-from-legacy-import-appengine-packages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants