-
Notifications
You must be signed in to change notification settings - Fork 2k
crypto/acme: add RetryAfter field to the Authorization, Order & Challenge objects #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
crypto/acme: add RetryAfter field to the Authorization, Order & Challenge objects #321
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ca91fe7
to
134302c
Compare
This PR (HEAD: 134302c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/685475. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/685475. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/685475. |
Message from Daniel McCarney: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/685475. |
Message from Adam Talbot: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/685475. |
… blocking, for example in Kubernetes controllers, the GetAuthorization can be used. This change adds the RetryAfter field to the Authorization, Order and Challenge objects returned by GetAuthorization, GetOrder and GetChallenge so it can be used by these implementations that use their own polling mechanism. The new RetryAfter field is populated by the "Retry-After" header in the HTTP response. Fixes golang/go#74454 Signed-off-by: Adam Talbot <adamtalbot93@gmail.com>
134302c
to
061aeaf
Compare
This PR (HEAD: 061aeaf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/685475. Important tips:
|
When using WaitAuthorization or WaitOrder is not practical due to its blocking,
for example in Kubernetes controllers, the GetAuthorization can be used.
This change adds the RetryAfter field to the Authorization, Order and Challenge
objects returned by GetAuthorization, GetOrder and GetChallenge so it can be
used by these implementations that use their own polling mechanism.
The new RetryAfter field is populated by the "Retry-After" header in the HTTP
response.
Fixes golang/go#74454