Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.24.0
Choose a base ref
...
head repository: golang/crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.26.0
Choose a head ref
  • 12 commits
  • 82 files changed
  • 9 contributors

Commits on Jun 4, 2024

  1. ssh: fail client auth immediately on receiving disconnect message

    Fixes golang/go#66991
    
    Change-Id: I60dd8a807578f162fda0e49bcd6fbf289d444396
    GitHub-Last-Rev: f88329d
    GitHub-Pull-Request: #293
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/581075
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
    Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    samiponkanen authored and gopherbot committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d4e7c9c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. ssh/test: make struct comment match struct name

    Change-Id: I9bfd61fe96d2bdaa890379a1a31b7e0f3f2b67ed
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/594435
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Run-TryBot: shuang cui <imcusg@gmail.com>
    Reviewed-by: Joedian Reid <joedian@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    cuishuang authored and gopherbot committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    1c74500 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. all: bump go.mod version and drop compatibility shims

    Also, remove the legacy import annotations.
    
    Fixes golang/go#68147
    
    Change-Id: Ibfcc9322f27224c0ba92ea42cd56912a7d8783fd
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/594256
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    FiloSottile authored and gopherbot committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a6a393f View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I0024d2803498fe98af80f14a4476a504c9aa6b5b
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/596835
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    gopherbot committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9fadb0b View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. x509roots/fallback: update bundle

    This is an automated CL which updates the NSS root bundle.
    
    Change-Id: I552ff9800e32294b25cc04ccc8fca3404ae3b93c
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/597095
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    gopherbot committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d66d9c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. x509roots/fallback/internal/goissue52287: delete

    By now Go 1.19 isn't supported, so there's no need to work around
    go.dev/issue/52287 in this module anymore.
    
    For golang/go#57792.
    For golang/go#52287.
    
    Change-Id: I3999cdb9ca419a2ab897c9143a4ec31f59da7d80
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/598495
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    dmitshur authored and gopherbot committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f2bc3a6 View commit details
    Browse the repository at this point in the history
  2. LICENSE: update per Google Legal

    Very minor tweaks:
     - Remove (c) pseudosymbol.
     - Remove "All Rights Reserved."
     - Change "Google Inc." (no longer exists) to "Google LLC".
    
    [git-generate]
    echo '
    ,s/\(c\) //
    ,s/ All rights reserved.//
    ,s/Google Inc./Google LLC/
    w
    q
    ' | sam -d LICENSE
    
    Change-Id: I6e885650c5701597f57dbf00c2abdcc7b393a703
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/598520
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Russ Cox <rsc@golang.org>
    rsc authored and gopherbot committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    80fd972 View commit details
    Browse the repository at this point in the history
  3. sha3: Avo port of keccakf_amd64.s

    This implementation utilizes the same registers found in the reference
    implementation, aiming to produce a minimal semantic diff between the
    Avo-generated output and the original hand-written assembly.
    
    To verify the Avo implementation, the reference and Avo-generated
    assembly files are fed to `go tool asm`, capturing the debug output into
    corresponding temp files. The debug output contains supplementary
    metadata (line numbers, instruction offsets, and source file references)
    that must be removed in order to obtain a semantic diff of the two
    files. This is accomplished via a small utility script written in awk.
    
    Commands used to verify Avo output:
    
    BASE="d66d9c31b4ae80d173d1187a9e40c188788dbdbc"
    go tool asm -o /dev/null -debug \
      <(git cat-file -p "$BASE":sha3/keccakf_amd64.s) \
      > /tmp/reference.s
    
    go tool asm -o /dev/null -debug \
      sha3/keccakf_amd64.s \
      > /tmp/avo.s
    
    normalize(){
      awk '{
        $1=$2=$3="";
        print substr($0,4)
      }'
    }
    
    diff <(normalize < /tmp/reference.s) <(normalize < /tmp/avo.s)
    
    Change-Id: I1c0ea516531355263b83d3b66a37df090e293cea
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/594655
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Russell Webb <russell.webb@protonmail.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    Garrett-Bodley authored and gopherbot committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e983fa2 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. ssh: remove go 1.21+ dependency on slices

    Fixes golang/go#68469
    
    Change-Id: Ieea3c444b0458d169a6ff224e59b3b815264de89
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/598775
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
    Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    imirkin authored and gopherbot committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    6879722 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. ssh: don't use dsa keys in integration tests

    DSA has been disabled by default since OpenSSH 9.8, so tests
    fail with newer versions of OpenSSH
    
    Change-Id: I57b9abde8845cd05116a637a21cbbb8af740b2e0
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/599955
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    drakkan authored and gopherbot committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    bb80217 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. ssh: add support for unpadded RSA signatures

    The original SSH RFC 4253 explicitly disallows padding. This applies to
    ssh-rsa signatures.
    
    The updated SSH RFC 8332 which defines the SHA2 RSA signature variants
    explicitly calls out the existence of signers who produce short
    signatures and specifies that verifiers may allow this behavior.
    
    In practice, PuTTY 0.81 and prior versions, as well as SSH.NET prior to
    2024.1.0 always generated short signatures. Furthermore, PuTTY is
    embedded in other software like WinSCP and FileZilla, which are updated
    on their own schedules as well. This leads to occasional unexplained
    login errors, when using RSA keys.
    
    OpenSSH server allows these short signatures for all RSA algorithms.
    
    Fixes golang/go#68286
    
    Change-Id: Ia60ece21bf9c111c490fac0c066443ed5ff7dd29
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/598534
    Reviewed-by: Nicola Murino <nicola.murino@gmail.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    imirkin authored and gopherbot committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3375612 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: Iae75e5fcbcfe3709820dd66638a763f662f8d939
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/603396
    Auto-Submit: Gopher Robot <gobot@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    gopherbot committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    5bcd010 View commit details
    Browse the repository at this point in the history
Loading