Add support for the TLS13-KDF algorithm #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasberlin
force-pushed
the
nberlin/add_tls13_kdf_support
branch
from
6ea7791 to
1ede3fc
Compare
qmuntal
requested changes
Apr 14, 2025
There was a problem hiding this comment.
Thanks for submitting this. I would prefer to have a dedicated on-shot API for TLS 1.3 KDF. Something like func SupportsTLS13KDF() and func ExpandTLS13KDF(fh func() hash.Hash, secret []byte, label string, context []byte, keyLength int) []byte. The caller can decide whether to use this or not based on SupportsTLS13KDF.
- Don't panic if there's no support - Don't export the parse function - Move unit tests to hkdf_interal_test.go which use the same package - Rework the parse function to return a boolean at the end
I believe I've addressed everything up to this comment. Back to it tomorrow. |
|
Oh, and this one:
|
Reduce to only an Expand function based on TLS13-KDF Remove associated cruft Add new unit tests
|
Ok, I think this is ready for another round |
qmuntal
requested changes
Apr 23, 2025
Co-authored-by: Quim Muntal <quimmuntal@gmail.com>
Co-authored-by: Quim Muntal <quimmuntal@gmail.com>
dagood
approved these changes
Apr 23, 2025
This was referenced Apr 29, 2025
Closed
nicholasberlin
added a commit
to nicholasberlin/openssl
that referenced
this pull request
May 1, 2025
* Add support for the TLS13-KDF algorithm * Change to opt-in * Code review suggestions - Don't panic if there's no support - Don't export the parse function - Move unit tests to hkdf_interal_test.go which use the same package - Rework the parse function to return a boolean at the end * Purge parsing Reduce to only an Expand function based on TLS13-KDF Remove associated cruft Add new unit tests * Update hkdf.go Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Update hkdf.go Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Be explicit, not clever. * Do not ignore testdata/ * panic for unknown openssl versions --------- Co-authored-by: Quim Muntal <quimmuntal@gmail.com>
nicholasberlin
added a commit
to nicholasberlin/openssl
that referenced
this pull request
May 5, 2025
* Add support for the TLS13-KDF algorithm * Change to opt-in * Code review suggestions - Don't panic if there's no support - Don't export the parse function - Move unit tests to hkdf_interal_test.go which use the same package - Rework the parse function to return a boolean at the end * Purge parsing Reduce to only an Expand function based on TLS13-KDF Remove associated cruft Add new unit tests * Update hkdf.go Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Update hkdf.go Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Be explicit, not clever. * Do not ignore testdata/ * panic for unknown openssl versions --------- Co-authored-by: Quim Muntal <quimmuntal@gmail.com>
nicholasberlin
added a commit
to nicholasberlin/openssl
that referenced
this pull request
May 5, 2025
* Add support for the TLS13-KDF algorithm * Change to opt-in * Code review suggestions - Don't panic if there's no support - Don't export the parse function - Move unit tests to hkdf_interal_test.go which use the same package - Rework the parse function to return a boolean at the end * Purge parsing Reduce to only an Expand function based on TLS13-KDF Remove associated cruft Add new unit tests * Update hkdf.go Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Update hkdf.go Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Be explicit, not clever. * Do not ignore testdata/ * panic for unknown openssl versions --------- Co-authored-by: Quim Muntal <quimmuntal@gmail.com>
qmuntal
added a commit
that referenced
this pull request
May 5, 2025
* Add support for the TLS13-KDF algorithm (#272) * Add support for the TLS13-KDF algorithm * Change to opt-in * Code review suggestions - Don't panic if there's no support - Don't export the parse function - Move unit tests to hkdf_interal_test.go which use the same package - Rework the parse function to return a boolean at the end * Purge parsing Reduce to only an Expand function based on TLS13-KDF Remove associated cruft Add new unit tests * Update hkdf.go Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Update hkdf.go Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Be explicit, not clever. * Do not ignore testdata/ * panic for unknown openssl versions --------- Co-authored-by: Quim Muntal <quimmuntal@gmail.com> * Fix up cherry-pick * hkdf: Replace nil salt with a slice of a preallocated all zeros buffer (#260) * hkdf: Replace nil salt with a slice of a preallocated all zeros buffer. This fixes HKDF when using KeyPair FIPS Provider for OpenSSL 3 * hkdf: fixed PR review comments * hkdf: second round of PR comment fixes * hkdf: third round of PR comment fixes --------- Co-authored-by: Quim Muntal <quimmuntal@gmail.com> Co-authored-by: samiponkanenssh <112563010+samiponkanenssh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are attempting to run a go binary on Ubuntu with FIPS enabled. But, the openssl shared object is rejecting our binary's usage of TLS1.3 because the
ivlength.microsoft/go#1626
This PR makes use of the KDF specialization carve out for TLS1.3 when the code detects it.This PR adds functions for external users to make use of TLS13-KDF