Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide archetype .Date that works unquoted for both TOML and YAML #3628

Closed
bep opened this issue Jun 22, 2017 · 6 comments
Closed

Provide archetype .Date that works unquoted for both TOML and YAML #3628

bep opened this issue Jun 22, 2017 · 6 comments

Comments

@bep
Copy link
Member

bep commented Jun 22, 2017

No description provided.

@bep bep added this to the v0.24.1 milestone Jun 22, 2017
@anthonyfok
Copy link
Member

This seems to be a regression that happened between v0.21 and v0.22 based on my limited/preliminary testing, and seemingly applies only to TOML, as in the following error:

ERROR 2017/06/22 13:41:27 failed to parse page metadata for "post/former.md": Near line 2 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got '+' instead

did not appear in v0.21 with an unquoted date in a TOML front matter, and hugo server continues to happily serves the website showing apparently correct article dates.

@bep
Copy link
Member Author

bep commented Jun 22, 2017

We switched TOML lib in 0.22.

@anthonyfok
Copy link
Member

We switched TOML lib in 0.22.

Thank you so much for your insight! BurntSushi/toml for front matter TOML since v0.22!
I was looking in completely wrong places.

I went ahead and submitted a PR at BurntSushi/toml#182. Hope that's the right way to do it. :-)

@bep bep added Bug Upstream and removed Bug labels Jun 22, 2017
@bep
Copy link
Member Author

bep commented Jun 23, 2017

FIxed in 0e1bda3

@bep bep closed this as completed Jun 23, 2017
@bep bep added Bug and removed Enhancement labels Jun 23, 2017
@anthonyfok
Copy link
Member

For reference:
Follow up PR at BurntSushi/toml#185 "Complete the testing for decoding datetime with UTC offset"

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants