Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Commit Message in .GitInfo #10905

Closed
marchof opened this issue Apr 19, 2023 · 3 comments · Fixed by #12642
Closed

Full Commit Message in .GitInfo #10905

marchof opened this issue Apr 19, 2023 · 3 comments · Fixed by #12642

Comments

@marchof
Copy link

marchof commented Apr 19, 2023

Current Behavior

The .GitInfo object hat a Subject field which contains the first line of the commit message

Proposed Bahavior

Add another field Message with the full commit message.

Reasoning

We implemented a content management system based on Git and Hugo. For the meta information it would be useful to present the full commit message, e.g. as a tooltip on top of the subject.

@bep
Copy link
Member

bep commented Apr 19, 2023

This would have to be added to this struct: https://github.com/bep/gitmap/blob/master/gitmap.go#L44

I'm not totally sure how that would work with the current git log approach.

@bep bep added Proposal and removed Enhancement labels Apr 19, 2023
@marchof
Copy link
Author

marchof commented Apr 19, 2023

@bep Thanks for the quick response and for providing this wonderful piece of software! This feature is not a blocker at all for us.

@bep bep modified the milestones: v0.113.0, v0.115.0 Jun 13, 2023
@bep bep modified the milestones: v0.115.0, v0.116.0 Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 5, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@bep bep modified the milestones: v0.122.0, v0.123.0, v0.124.0 Jan 27, 2024
@bep bep modified the milestones: v0.124.0, v0.125.0 Mar 4, 2024
PeskyPotato added a commit to PeskyPotato/hugo that referenced this issue Jul 5, 2024
Updated bep/gitmap to v1.4.0, to get commit message's Body.
Added Body to GitInfo struct.

Fixes gohugoio#10905
PeskyPotato added a commit to PeskyPotato/hugo that referenced this issue Jul 5, 2024
Included an example for commit Body exposed by GitInfo.

Fixes gohugoio#10905
PeskyPotato added a commit to PeskyPotato/hugo that referenced this issue Jul 5, 2024
Updated bep/gitmap to v1.4.0, to get commit message's Body.
Added Body to GitInfo struct. Docs upated with commit body example.

Fixes gohugoio#10905
PeskyPotato added a commit to PeskyPotato/hugo that referenced this issue Jul 5, 2024
Updated bep/gitmap to v1.4.0, to get commit message's Body.
Added Body to GitInfo struct. Docs upated with commit body example.

Fixes gohugoio#10905
@bep bep closed this as completed in #12642 Jul 6, 2024
@bep bep closed this as completed in 0ee2610 Jul 6, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants