Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to display IP address in log? #5561

Closed
LoLei opened this issue Aug 8, 2018 · 7 comments
Closed

Possible to display IP address in log? #5561

LoLei opened this issue Aug 8, 2018 · 7 comments
Assignees
Labels

Comments

@LoLei
Copy link

LoLei commented Aug 8, 2018

Is it possible to display the IP address of the machine from which actions are done in the web UI activity log?

E.g. instead of just showing that username admin did operation pull on op_time <timestamp> for some repo, show the IP that was used to issue that operation in addition?

I have different machines logged in as the same user, and would like to differentiate between those machine based on their IP. Otherwise they all show up as the same user in the log, with no way to tell which machine actually did the logged operation.

Is it possible to do this, or does Harbor not even receive the IP, i.e. the technology is not there yet?

@steven-zou
Copy link
Contributor

steven-zou commented Aug 8, 2018

@LoLei

Thanks for submitting the idea. From the technical perspective, I don't think there is block issue to support that requirement. But we need to review and discuss if it is a reasonable scenario from both tech and security perspectives.

@LoLei
Copy link
Author

LoLei commented Aug 8, 2018

If it's a security or privacy issue, it might be a good idea to either let SysAdmin users toggle the IP display in the web UI configuration, or add a setting somewhere else, e.g. harbor.cfg.

In any case, making it optional would be best.

@ghost
Copy link

ghost commented Aug 8, 2018

I like the idea @LoLei. Agreed with @steven-zou that we should discuss the scenario a bit more. Are you able to hop on our community call(s) and discuss? Happy to help you through the PR process if you're willing to contribute the feature, too!

@steven-zou steven-zou self-assigned this Aug 9, 2018
@LoLei
Copy link
Author

LoLei commented Aug 9, 2018

@clouderati Unfortunately I won't be available for a few weeks after today, so I'd rather not commit to anything. I'm glad my idea is taken into consideration though!

@ghost
Copy link

ghost commented Aug 13, 2018

No worries @LoLei – very much appreciate your input. Hope to see you on a community call sometime soon. 😄

@steven-zou
Copy link
Contributor

@LoLei
Please refer goharbor/community#10 for more info

@stale
Copy link

stale bot commented Feb 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants