Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current tests and linting failing due to dagger layout #200

Closed
tylerauerbeck opened this issue Oct 5, 2024 · 0 comments · Fixed by #201
Closed

Current tests and linting failing due to dagger layout #200

tylerauerbeck opened this issue Oct 5, 2024 · 0 comments · Fixed by #201

Comments

@tylerauerbeck
Copy link
Contributor

Without any further code changes, running tests and or lint (via dagger or golangci-lint directly) fails due to what appears to be the current layout of dagger.

╰─❯ go test -v ./...
# github.com/goharbor/harbor-cli
./main.go:29:13: undefined: dag
./main.go:33:15: undefined: dag
./main.go:37:37: undefined: dag
./main.go:39:41: undefined: dag
./main.go:58:9: undefined: dag
./main.go:60:35: undefined: dag
./main.go:62:39: undefined: dag
./main.go:103:17: undefined: dag
./main.go:110:21: undefined: dag
./main.go:111:17: undefined: dag
./main.go:111:17: too many errors
FAIL	github.com/goharbor/harbor-cli [build failed]
╰─❯ dagger call lint
✔ connect 0.1s
✔ initialize 0.4s
✔ prepare 0.0s
✔ harborCli: HarborCli! 0.0s
✔ HarborCli.lint: Container! 0.8s
✘ Container.sync: ContainerID! 10.8s
! process "golangci-lint run --timeout 5m" did not complete successfully: exit code: 1

Setup tracing at https://dagger.cloud/traces/setup. To hide: export STOPIT=1

Error: response from query: input: container.from.withMountedCache.withEnvVariable.withMountedCache.withEnvVariable.withMountedDirectory.withWorkdir.withExec.sync resolve: process "golangci-lint run --timeout 5m" did not complete successfully: exit code: 1

Stdout:
main.go:1: : # github.com/goharbor/harbor-cli
./main.go:29:13: undefined: dag
./main.go:33:15: undefined: dag
./main.go:37:37: undefined: dag
./main.go:39:41: undefined: dag
./main.go:58:9: undefined: dag
./main.go:60:35: undefined: dag
./main.go:62:39: undefined: dag
./main.go:103:17: undefined: dag
./main.go:110:21: undefined: dag
./main.go:111:17: undefined: dag
./main.go:111:17: too many errors (typecheck)
package main
Run 'dagger call lint --help' for usage.

I believe some quick cleanup of the dagger structure itself will resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant