Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop down option not updating correctly #47

Open
muthukurukrishnakanth opened this issue Jan 7, 2019 · 1 comment
Open

Drop down option not updating correctly #47

muthukurukrishnakanth opened this issue Jan 7, 2019 · 1 comment
Labels

Comments

@muthukurukrishnakanth
Copy link

muthukurukrishnakanth commented Jan 7, 2019

Hi Team,

We are facing one issue with dependent drop downs.
Please see below scenario.

Scenario:

Filter 1: Airline Filter 2: Technology
option1: AAL option1: ATG, 2KU
option2: ACA option2: 2KU, ATG4

We have 5 dependent dropdown (filters) like Airline, Fleet type, Technology and some other filters.

Let say when we select one option in airline filter (say 'AAL') and it will populate all the available options like ('ATG', '2KU') for the technology filter based on the selected airline and when we select any of the technology option say 2KU and again change the Airline filter to ACA option then the technology filter options are not updating with available technology options for ACA airline (say 2KU, ATG4).
And it is happening with all other filters.

We have debugged the root cause of that issue and below code is stopping the re rendering of the drop downs with updated options.

if (newProps.value !== this.state.value) {

If we remove this line of code it is working fine.

So, Please look in to this issue.

@muthukurukrishnakanth muthukurukrishnakanth changed the title Dropdown option are not updating correctly Drop down option not updating correctly Jan 7, 2019
@Max-Z80
Copy link

Max-Z80 commented Apr 11, 2019

I make the same observation here. It would be nice to fix this. As a workaround, I noticed that when the prop 'text' is changed, the component is re-rendered and this takes into account changes of 'data' props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants