Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go.mod and go.sum #518

Open
JAicewizard opened this issue Nov 16, 2018 · 6 comments
Open

add go.mod and go.sum #518

JAicewizard opened this issue Nov 16, 2018 · 6 comments

Comments

@JAicewizard
Copy link

add support for go modules.

@donaldgraham
Copy link
Contributor

We think we should wait until go modules are more official before we investigate further.

@jkellz-dev
Copy link

Modules is pretty official at this point. Any chance this is being revisited?

@mimoo
Copy link

mimoo commented Sep 11, 2019

yep, can confirm, totally broken with go modules

@hyphenlee
Copy link

any update for go modules?

@ergoz
Copy link

ergoz commented Oct 8, 2019

i have a pain with paths for gogofast and etc at this moment with go modules

On windows it will be something like this to make it work:

protoc -I=./protobuf \
    -I=. \
    -I=$GOPATH/src \
    -I=$GOPATH/pkg/mod/github.com/gogo/protobuf@v1.3.0 \
    --gogofast_out=./structs/gogofast \
    gogo.proto

this path i should fix every time gogo release updates

@mkeeler
Copy link

mkeeler commented Oct 30, 2019

It would be amazing if this were go module aware and prevent me from having to find the right module/version path to include.

@ergoz My work around was to use go list -f '{{ .Dir }}' -m github.com/gogo/protobuf to determine the path to the right version of gogo/protobuf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants