Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json unmarshalling doesn't handle "null" into pointer types correctly #319

Closed
tamird opened this issue Aug 5, 2017 · 9 comments
Closed

Comments

@tamird
Copy link
Contributor

tamird commented Aug 5, 2017

Fixed upstream in golang/protobuf#394.

@awalterschulze
Copy link
Member

Sorry for the delay. I'll get to this asap.

@tamird
Copy link
Contributor Author

tamird commented Aug 7, 2017 via email

@awalterschulze
Copy link
Member

I want to merge all the diffs in between first, if there are any.

@tamird
Copy link
Contributor Author

tamird commented Aug 7, 2017 via email

@awalterschulze
Copy link
Member

I would prefer to do that myself, just because I think it will be harder to review than doing it.
Maybe I am wrong.

@tamird
Copy link
Contributor Author

tamird commented Aug 7, 2017 via email

@awalterschulze
Copy link
Member

Ok starting now.

@awalterschulze
Copy link
Member

I really do appreciate the gesture though. It is quite a tedious process. I did leave it a bit too long.

@awalterschulze
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants