-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json unmarshalling doesn't handle "null" into pointer types correctly #319
Comments
This was referenced Aug 5, 2017
Sorry for the delay. I'll get to this asap. |
I'm actually doing it right now; I'll send a PR shortly.
…On Mon, Aug 7, 2017 at 2:20 PM, Walter Schulze ***@***.***> wrote:
Sorry for the delay. I'll get to this asap.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#319 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABdsPIyvrf13KMQpp0jUFyCDX1loiCZ6ks5sV1VjgaJpZM4Oul48>
.
|
I want to merge all the diffs in between first, if there are any. |
Yep, I'm doing that.
…On Mon, Aug 7, 2017 at 2:22 PM, Walter Schulze ***@***.***> wrote:
I want to merge all the diffs in between first, if there are any.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#319 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABdsPOmxdV0PU6GVapneNZuU-CdYylSoks5sV1XzgaJpZM4Oul48>
.
|
I would prefer to do that myself, just because I think it will be harder to review than doing it. |
Go for it.
…On Mon, Aug 7, 2017 at 2:25 PM, Walter Schulze ***@***.***> wrote:
I would prefer to do that myself, just because I think it will be harder
to review than doing it.
Maybe I am wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#319 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABdsPFANspUapBKMJtg5ORcmX2RnKD6Dks5sV1aBgaJpZM4Oul48>
.
|
Ok starting now. |
I really do appreciate the gesture though. It is quite a tedious process. I did leave it a bit too long. |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fixed upstream in golang/protobuf#394.
The text was updated successfully, but these errors were encountered: