build(contrib/rpc/grpcx): use grpc.NewClient instead of grpc.Dial #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and improve some code indentations
oldme-git
changed the title
|
@oldme-git 需要等待#3688 合并后更新该pr，同样放到 |
@oldme-git needs to wait for #3688 to be merged and then update the pr, and also put it into the |
gqcn
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear reviewer:
升级依赖至 Go 1.21
在
rpc的新版本中已经弃用grpc.Dial:https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md
另外，减少了一些代码的缩进