Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is an unofficial fork, go.mod has been fixed in the official upstream on gitlab.com/go-box/pongo2gin #1

Open
robvdl opened this issue Aug 20, 2022 · 0 comments

Comments

@robvdl
Copy link
Contributor

robvdl commented Aug 20, 2022

Sorry it took a while to get to merging this fix with the go.mod file, I wasn't pinged about the change on gitlab.com/go-box/pongo2gin (official upstream) until my name was referenced which led to a lot of forks being created in the mean time. And since then almost a year had passed.

One of the forks (not this one) also had the cheek to send a PR to Pongo2 and update the link to point to his repo AND update the copyright to himself. He was snapped though by the Pongo2 devs who noticed a PR changing the link and notified me.

Anyway, official repo is on gitlab.com/go-box/pongo2gin, the new version has a small addition by a contributor to allow template sets. We've also started pinning against specific version of Pongo2, although I dropped the v1 version as it was broken and just too old.

Anyway MIT license allows forks, that isn't a problem. But you might want to change to the official upstream going forward, since we merged the go.mod change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant