Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiber seems not support cancelContext like net/http 🤔 #1292

Open
phxism opened this issue Apr 23, 2023 · 2 comments
Open

fiber seems not support cancelContext like net/http 🤔 #1292

phxism opened this issue Apr 23, 2023 · 2 comments
Labels
wontfix This will not be worked on

Comments

@phxism
Copy link

phxism commented Apr 23, 2023

Question description
fiber seems not support cancelContext like net/http, for demo case, see context
So code in the sub project "docker-mariadb-clean-arch"

customContext, cancel := context.WithCancel(context.Background())
	defer cancel()

should be change into

customContext, cancel := context.WithTimeout(context.Background(), 10*time.Second)
	defer cancel()

I am a green hand for golang and fiber, so i'm not sure that if i am right.

@welcome
Copy link

welcome bot commented Apr 23, 2023

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template!

@stale
Copy link

stale bot commented Aug 12, 2023

👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant