-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(middleware/csrf): Update config TrustedOrigin comments #2963
chore(middleware/csrf): Update config TrustedOrigin comments #2963
Conversation
WalkthroughThe update enhances the CSRF middleware's configuration documentation, specifically improving clarity on how subdomains are matched. It introduces the capability for wildcard matching at any subdomain level, ensuring a more flexible and comprehensive understanding for developers. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2963 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 116 116
Lines 8411 8411
=======================================
Hits 6967 6967
Misses 1106 1106
Partials 338 338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request updates the comments about the TrustedOrigins config field in the middleware/csrf/config.go file to reflect the behaviour introduced in PR #2925.
Summary by CodeRabbit