🧹 v3 (chore): Update test workflow to use gotestsum #2895
Conversation
nickajacks1
requested review from
gaby,
sixcolors,
ReneWerner87 and
efectn
and removed request for
a team
WalkthroughThis update integrates Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/test.yml (1 hunks)
Additional comments: 2
.github/workflows/test.yml (2)
- 33-36: The addition of the
gotestsumsetup step usingautero1/action-gotestsum@v2.0.0is a good practice for ensuring that the required version ofgotestsumis installed. However, it's important to verify the reliability and maintenance status of the third-party GitHub Action, as well as the compatibility ofgotestsumversion1.11.0with the project's requirements.- 38-38: The modification of the test command to use
gotestsum -f testname -- ./... -raceis a positive change for enhancing test output readability and running tests with the race detector enabled. Ensure that the chosen output format (testname) meets the project's needs and consider the potential overhead introduced by the race detector, especially in CI environments where resources may be limited.
|
Output looks so much better :-) |
gaby
changed the title
|
@nickajacks1 There's a merge conflict now. Coverage reports were addsd to the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2895 +/- ##
=======================================
Coverage ? 82.49%
=======================================
Files ? 116
Lines ? 8321
Branches ? 0
=======================================
Hits ? 6864
Misses ? 1110
Partials ? 347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Use gotestsum instead of
go testto make test workflow output easier to read. In particular, test failures are summarized at the end, so we no longer have to dig through the logs to find what went wrong.Uses https://github.com/marketplace/actions/gotestsum-installer
Fixes #2885
Type of change
Please delete options that are not relevant.
Checklist
Before you submit your pull request, please make sure you meet these requirements:
Summary by CodeRabbit
gotestsum.gotestsumversion and format.