Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 [Proposal]: Fiber v3 add function to create client and pass fasthttp custom client in #3107

Open
goriunov opened this issue Aug 20, 2024 · 4 comments
Labels
✏️ Feature hacktoberfest 🚀 Open for Hacktoberfest contributions! 📝 Proposal v3

Comments

@goriunov
Copy link

goriunov commented Aug 20, 2024

Feature Proposal Description

I believe there should be a way to pass custom fasthttp client in to the fiber http client, to allow more granular fine tuning by the users.

Alignment with Express API


HTTP RFC Standards Compliance


API Stability


Feature Examples

Naming can be improved but something along the lines:

cc := client.NewWithFasthttpClien(&fasthttp.Client{...})


### Checklist:

- [X] I agree to follow Fiber's [Code of Conduct](https://github.com/gofiber/fiber/blob/master/.github/CODE_OF_CONDUCT.md).
- [X] I have searched for existing issues that describe my proposal before opening this one.
- [X] I understand that a proposal that does not meet these guidelines may be closed without explanation.
Copy link

welcome bot commented Aug 20, 2024

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@gaby
Copy link
Member

gaby commented Aug 20, 2024

@efectn Thoughts? Seems reasonable

@luk3skyw4lker
Copy link
Contributor

Couldn't this also be achieved using an option within the existing New method? One option like CustomFastHttpClient or something that when omitted defaults to the internal Fiber fasthttp client. Not sure if this is good but just throwing ideas here

@gaby gaby added the hacktoberfest 🚀 Open for Hacktoberfest contributions! label Oct 18, 2024
@mitulagr2
Copy link

I'll take this if you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Feature hacktoberfest 🚀 Open for Hacktoberfest contributions! 📝 Proposal v3
Projects
None yet
Development

No branches or pull requests

4 participants