Merge pull request matplotlib#12046 from anntzer/htmlwriter

Make HTMLWriter constructor a bit more strict.
godsic · Sep 6, 2018 · ef2cf8c · ef2cf8c
2 parents 5e01393 + ce95439
commit ef2cf8c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/doc/api/next_api_changes/2018-09-06-AL-HTMLWriter.rst b/doc/api/next_api_changes/2018-09-06-AL-HTMLWriter.rst
@@ -0,0 +1,4 @@
+The HTMLWriter constructor is more strict
+`````````````````````````````````````````
+It no longer normalizes unknown values of *default_mode* to 'loop', but errors
+out instead.
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
@@ -846,8 +846,8 @@ def __init__(self, fps=30, codec=None, bitrate=None, extra_args=None,
         self._bytes_limit *= 1024 * 1024
 
         if self.default_mode not in ['loop', 'once', 'reflect']:
-            self.default_mode = 'loop'
-            _log.warning("unrecognized default_mode: using 'loop'")
+            raise ValueError(
+                "unrecognized default_mode {!r}".format(self.default_mode))
 
         super().__init__(fps, codec, bitrate, extra_args, metadata)