Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cities to fellows. #16

Open
harigopal opened this issue Feb 17, 2017 · 2 comments
Open

Add cities to fellows. #16

harigopal opened this issue Feb 17, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@harigopal
Copy link
Contributor

harigopal commented Feb 17, 2017

Resources under a fellow are associated to his city.

NationalFinanceHead should be able to add cities and pick the city when creating a Fellow.

@ajaleelp
Copy link
Contributor

The first part of this has been completed. A City model was introduced and the required associations wired. Will keep the issue open until the second part is tackled.

@harigopal
Copy link
Contributor Author

harigopal commented Apr 8, 2017

@ajaleelp I've been wondering whether it might make sense to store the value of city for a user in the User model instead of in the Fellow model - mainly for ease of editing (#38). I suppose it would be possible to expose the user.fellow.city in the user's edit form conditionally. Not at all sure what all the differences would be in storing city in Fellow vs User. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants