Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing getter for sharp window corners. #99879

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Add missing getter for sharp window corners. #99879

merged 1 commit into from
Dec 2, 2024

Conversation

Lielay9
Copy link
Contributor

@Lielay9 Lielay9 commented Nov 30, 2024 •
edited
Loading

Noticed while issuing #99856, seems to just been forgotten from #97005.

@Lielay9 Lielay9 requested a review from a team as a code owner November 30, 2024 17:16
adamscott
adamscott requested changes Nov 30, 2024
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It does seem that the getter is missing. But I just have just one nitpicky comment about this.

Thanks for your PR!

platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
@Lielay9 Lielay9 force-pushed the missing-sharp-corner_getter branch from ba1a164 to b045523 Compare November 30, 2024 17:25
@adamscott adamscott added this to the 4.4 milestone Nov 30, 2024
@adamscott adamscott requested a review from Repiteo November 30, 2024 17:27
@akien-mga akien-mga merged commit 9babf66 into godotengine:master Dec 2, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Lielay9 Lielay9 deleted the missing-sharp-corner_getter branch December 2, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Repiteo Repiteo Repiteo approved these changes

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:porting
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Lielay9 @akien-mga @adamscott @Repiteo