Integrate mimalloc allocator #99686
Open
Integrate mimalloc allocator #99686
+17,540
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
reviewed
Nov 25, 2024
RandomShaper
force-pushed
the
godot_mimalloc
branch
5 times, most recently
from
8bd1a51 to
43f1217
Compare
Repiteo
reviewed
Nov 26, 2024
mimalloc/windows_override.cpp
Outdated
Comment on lines
118
to
122
| #if 0 // This one doesn't work. | ||
| __declspec(restrict) unsigned short *wcsdup(const unsigned short *s) { | ||
| return mi_wcsdup(s); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Any further context for why this one doesn't work, and how relevant it is compared to the rest of the functions?
There was a problem hiding this comment.
error C2733: 'wcsdup': you cannot overload a function with 'extern "C"' linkage
I've rewritten this file and now it's more "traceable" and contains remarks.
RandomShaper
force-pushed
the
godot_mimalloc
branch
2 times, most recently
from
3b6d52a to
29e9a4f
Compare
This was referenced Nov 27, 2024
RandomShaper
force-pushed
the
godot_mimalloc
branch
3 times, most recently
from
d2c537d to
d1833e1
Compare
RandomShaper
force-pushed
the
godot_mimalloc
branch
from
d1833e1 to
bb886cc
Compare
|
If it helps somehow, I tried an approach of mimalloc a while ago: DeeJayLSP@eae9709 However, getting it to work properly was beyond my knowledge. I observed there is a One thing that I did manage to do however, was linking with the system-provided mimalloc for Linux packages using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed #99427, an integration of mimalloc.
Since I already had an integration in a private fork, I've decided to upstream it so we can decide which one is the preferred way.
Main highlight is that this is a low-level integration: as such it also hooks into allocations made by 3rd-party code (TLS storage, C/C++ standard library containers, 3rd-party libraries, etc.).
Disclaimer:
This has been thoroughly tested downstream on Windows and certain non-standard platforms. This PR would need some work to add the low-level integration to all the other platforms. On Mac it may work out-of-the-box, though.
2024-11-26:
malloc()and friends.2024-11-26 (2):