Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Scale Selection in Animation tab #98419

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Improve Scale Selection in Animation tab #98419

merged 1 commit into from
Nov 26, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 22, 2024

  • Select text field after opening dialog
  • Allow accepting by submitting number
sqPazn2OQG.mp4

@KoBeWi KoBeWi added this to the 4.x milestone Oct 22, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner October 22, 2024 13:54
TokageItLab
TokageItLab approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's curious that the selection does strange things when scrubbed since the up down button is implemented out side of the spinbox externally, but I assume this PR is not directly related to it and can be followed up later.

@TokageItLab TokageItLab modified the milestones: 4.x, 4.4 Nov 24, 2024
@Repiteo Repiteo merged commit bbc5469 into godotengine:master Nov 26, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 26, 2024

Thanks!

@KoBeWi KoBeWi deleted the dialog_scalar branch November 26, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees
No one assigned
Labels
enhancement topic:animation topic:editor usability
Projects
Animation Team Issue Triage
Status: Done
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@KoBeWi @Repiteo @TokageItLab