Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 24-bit color escape sequences, simplify print_rich BBCode parsing. #98118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for 24-bit color escape sequences, simplify print_rich BBCode parsing. #98118

wants to merge 1 commit into from
+170 −73

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 12, 2024 •
edited
Loading

  • Add support for 24-bit color escape sequences.
  • Change BBCode parsing to loop over string once, instead of using multiple replace calls.

Fixes #87899
Fixes #97432

Screen.Recording.2024-10-12.at.16.47.13.mov

@bruvzg bruvzg added this to the 4.x milestone Oct 12, 2024
@charlie-sans
Copy link

can't wait for this to be a thing with godot!

@bruvzg bruvzg marked this pull request as ready for review October 13, 2024 19:33
@bruvzg bruvzg requested review from a team as code owners October 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement performance topic:core
Projects
None yet
Milestone
4.x
3 participants
@bruvzg @charlie-sans @Calinou