Fix uneditable LineEdit, TextEdit and CodeEdit virtual keyboard popup on mobile
#98012
Conversation
AThousandShips
added
bug
topic:input
topic:gui
cherrypick:4.3
|
Looks good to me! Alas, I cannot do reviews. |
syntaxerror247
force-pushed
the
lineEdit-bug-fix
branch
from
bcd6533
to
7857007
Compare
syntaxerror247
changed the title
LineEdit Virtual keyboard popup on mobileLineEdit, TextEdit and CodeEdit virtual keyboard popup on mobile
|
@SkogiB if you are able to test this you are very welcome to provide feedback, a review by a maintainer will be required to merge this but anyone that is able to provide feedback is welcome to do so, especially testing (it helps a lot to test on different hardware and contexts) |
|
Beware I'm not too familiar with lineEdit and TextEdit. This looks good but I think it would be best to keep it consistant between the two classes. Either it makes no sense to want to show when it is disabled and it should be prevented in both case or it might make some case and then in both case it should be handled before calling. I don't see any reason to show it so I'm more in favour of preventing it but I'm not that familiar with those classes so TIWAGOS. |
syntaxerror247
force-pushed
the
lineEdit-bug-fix
branch
from
7857007
to
14dd595
Compare
|
@ajreckof I have updated it to keep it consistant between the two classes. Now check for editable is done before calling |
Fixes #97993