Remove duplicated read only checks in EditorSpinSlider
#96632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made read only checks in EditorSpinSlider's implementation to use `read_only` directly for consistency.
KoBeWi
approved these changes
Sep 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are checks for both
read_onlyandis_read_only()at the beginning ofEditorSpinSlider::_grabber_gui_input(). They were added by two separate PRs, and it is probably due to one of them rebasing after the other is merged :)editor_spin_slider.cpphas overall mixed use ofread_onlyandis_read_only(). The numbers are almost the same (7 vs 9).Since
is_read_only()is not virtual and is a plain getter, I also made read only checks inEditorSpinSlider's implementation to useread_onlydirectly for consistency in this PR.