Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Fix invalid return value when multiple permission requests are dispatched #92709

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Android: Fix invalid return value when multiple permission requests are dispatched #92709

merged 1 commit into from
Jun 3, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jun 3, 2024

#89260 refactored the previous logic and in the process accidentally changed the return value when requesting multiple permissions from false to true

@m4gr3d m4gr3d added this to the 4.3 milestone Jun 3, 2024
@m4gr3d m4gr3d requested a review from a team as a code owner June 3, 2024 00:27
@akien-mga akien-mga merged commit 7118487 into godotengine:master Jun 3, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_request_permissions_return_value branch June 3, 2024 12:28
@akien-mga akien-mga changed the title Fix invalid return value when multiple permission requests are dispatched Android: Fix invalid return value when multiple permission requests are dispatched Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:android regression topic:porting
Projects
4.x Release Blockers
Status: Unassessed
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@m4gr3d @akien-mga