Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If SpinBox text can't be parsed use last updated text #88794

Merged
merged 1 commit into from
Feb 28, 2024
Merged

If SpinBox text can't be parsed use last updated text #88794

merged 1 commit into from
Feb 28, 2024

Conversation

ryevdokimov
Copy link
Contributor

Fixes: #88778

Before:

2024-02-24.20-12-54.mp4

After:

2024-02-24.20-14-24.mp4

@ryevdokimov ryevdokimov requested a review from a team as a code owner February 25, 2024 01:15
@KoBeWi KoBeWi added this to the 4.3 milestone Feb 25, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Feb 27, 2024

Apparently the issue is a regression from #80699
The bug was already fixed in the past like this: #81094 It should be sufficient, so I think reapplying the old fix would be better.

@ryevdokimov
Copy link
Contributor Author

I agree, it does exactly the same thing. Tested and pushed.

@akien-mga akien-mga merged commit b431314 into godotengine:master Feb 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@ryevdokimov ryevdokimov deleted the fix-spinbox branch March 1, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Unfocusing empty SpinBox leaves it empty
4 participants
@ryevdokimov @KoBeWi @akien-mga @AThousandShips