Fix invalid 3-to-4 renames of add_animation to add_animation_library
#86647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
topic:animation
cherrypick:4.1
AThousandShips
commented
Dec 30, 2023
| @@ -644,7 +644,6 @@ const char *RenamesMap3To4::csharp_function_renames[][2] = { | |||
| { "_SetPlaying", "SetPlaying" }, // AnimatedSprite3D | |||
| { "_ToplevelRaiseSelf", "_TopLevelRaiseSelf" }, // CanvasItem | |||
| { "_UpdateWrapAt", "_UpdateWrapAtColumn" }, // TextEdit | |||
| { "AddAnimation", "AddAnimationLibrary" }, // AnimationPlayer | |||
There was a problem hiding this comment.
As none of the commented out conversions are mentioned in the same way in the C# part I just removed it, can add it as a commented out part if desired
AThousandShips
changed the title
add_animation to add_animation_libraryadd_animation to add_animation_library
AThousandShips
commented
Dec 30, 2023
| @@ -163,6 +163,7 @@ const char *RenamesMap3To4::gdscript_function_renames[][2] = { | |||
|
|
|||
| // { "_set_name", "get_tracker_name" }, // XRPositionalTracker -- CameraFeed uses this. | |||
| // { "_unhandled_input", "_unhandled_key_input" }, // BaseButton, ViewportContainer -- Breaks Node, FileDialog, SubViewportContainer. | |||
| // { "add_animation", "add_animation_library" }, // AnimationPlayer -- Breaks SpriteFrames (and isn't a correct conversion). | |||
There was a problem hiding this comment.
Technically this now applies to AnimationMixer, but wanting to allow cherry picking of this so not changing this
AThousandShips
force-pushed
the
anim_fix
branch
from
73edbc4
to
90fe583
Compare
This rename breaks `SpriteFrames` and also isn't valid as the new method takes an `AnimationLibrary`, not an `Animation`
AThousandShips
force-pushed
the
anim_fix
branch
from
90fe583
to
4b7ea9f
Compare
akien-mga
approved these changes
Jan 11, 2024
|
Thanks! |
|
Thank you! |
YuriSizov
removed
cherrypick:4.2
|
Cherry-picked for 4.1.4. (Same caveat.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rename breaks
SpriteFramesand also isn't valid as the new method takes anAnimationLibrary, not anAnimationThis change needs a more elaborate fix and should be mentioned in the migration page, see:
Document migration from 3.x for AnimationPlayer.add_animation #86611
Fixes: Upgrading from 3 to 4 changes functions to invalid functions #86646