Cleanup in undo in TextEdit and LineEdit
#86085
Open
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Oct 21, 2024
| @@ -4024,7 +4024,7 @@ void TextEdit::redo() { | |||
| } | |||
| _push_current_op(); | |||
|
|
|||
| if (undo_stack_pos == nullptr) { | |||
| if (!has_redo()) { | |||
There was a problem hiding this comment.
Should the same change be done in undo()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both
TextEditandLineEdit, the Undo and Redo functions seemed to check for themselves whether there was an Undo/Redo available rather than using the existinghas_undoorhas_redofunctions. I decided to make them use them to remove repetition.Only exception was the
TextEditUndofunction. I noticed its check for an Undo was slightly different from thehas_undofunction. I decided to leave it alone.