-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement disabled state for Checkbox in Tree #84845
Merged
YuriSizov
merged 1 commit into
godotengine:master
from
DarkMessiah:tree-disabled-checkbox
Dec 19, 2023
Merged
Implement disabled state for Checkbox in Tree #84845
YuriSizov
merged 1 commit into
godotengine:master
from
DarkMessiah:tree-disabled-checkbox
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd say yes. Unless there is no way to set both disabled and indeterminate. |
DarkMessiah
force-pushed
the
tree-disabled-checkbox
branch
from
November 13, 2023 14:23
47baee0
to
32729c3
Compare
KoBeWi
reviewed
Nov 13, 2023
KoBeWi
reviewed
Nov 13, 2023
KoBeWi
approved these changes
Nov 13, 2023
DarkMessiah
force-pushed
the
tree-disabled-checkbox
branch
from
November 13, 2023 19:31
32729c3
to
1c8e1dc
Compare
That looks nice! Thanks for suggestion. I can add @KoBeWi What do you think? |
Makes sense I think. |
DarkMessiah
force-pushed
the
tree-disabled-checkbox
branch
from
November 14, 2023 14:20
1c8e1dc
to
f61bd1d
Compare
DarkMessiah
force-pushed
the
tree-disabled-checkbox
branch
from
November 14, 2023 14:53
f61bd1d
to
73de590
Compare
KoBeWi
approved these changes
Nov 14, 2023
Calinou
reviewed
Nov 15, 2023
DarkMessiah
force-pushed
the
tree-disabled-checkbox
branch
from
November 15, 2023 16:14
73de590
to
ff8797e
Compare
Fixed the base theme. Optimized |
YuriSizov
approved these changes
Dec 19, 2023
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add disabled icons for Checkbox in Tree
EDIT: Added icon for Indeterminate Disabled state.
EDIT2: Fixed the base theme.