Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disabled state for Checkbox in Tree #84845

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

DarkMessiah
Copy link
Contributor

@DarkMessiah DarkMessiah commented Nov 13, 2023

Add disabled icons for Checkbox in Tree

Editor Theme Base Theme
image image

EDIT: Added icon for Indeterminate Disabled state.
EDIT2: Fixed the base theme.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 13, 2023

P.S. Do we need disabled state for intermediate Checkbox?

I'd say yes. Unless there is no way to set both disabled and indeterminate.

scene/gui/tree.cpp Outdated Show resolved Hide resolved
doc/classes/Tree.xml Outdated Show resolved Hide resolved
@seppoday
Copy link

seppoday commented Nov 14, 2023

Little suggestion for discussion. If we also change disabled font color it will be easier to differentiate "Unchecked" and "Unchecked Disabled". Right now, they are pretty much the same.

Difference could be more subtle than what I've shown. I've used same grey as on disabled checkbox.

obraz

@DarkMessiah
Copy link
Contributor Author

That looks nice! Thanks for suggestion. I can add font_disable_color for Tree and use it only for check mode.

@KoBeWi What do you think?

@KoBeWi
Copy link
Member

KoBeWi commented Nov 14, 2023

Makes sense I think.

@DarkMessiah
Copy link
Contributor Author

Added font_disabled_color. It is only used for a CELL_MODE_CHECK mode cell when it's non-editable.
image

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Nov 14, 2023
@DarkMessiah
Copy link
Contributor Author

Fixed the base theme. Optimized indeterminate.svg and added indeterminate_disabled.svg

@YuriSizov YuriSizov merged commit 7aae85e into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@DarkMessiah DarkMessiah deleted the tree-disabled-checkbox branch December 19, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants