Fix VisualShader connection use after free.

[alesliehughes]

Coverity has picked up this as a "Use after free", the object E is deteled bu erase but is used straight after multiple times e->get().
Moving to the end of the if seems to make the most sense.

[jsjtxietian]

IMHO you can use a more comprehensive commit message like your pr title

[YuriSizov]

Could probably use some refactoring to avoid doing E->get() a bunch of times, but looks fine as a quick fix.

[alesliehughes]

Could probably use some refactoring to avoid doing E->get() a bunch of times, but looks fine as a quick fix.

Sure, I can refactor it.

[alesliehughes]

I've refactored the code as a second commit. I can squish them if you prefer.

[YuriSizov]

Sorry if I wasn't clear, but that wasn't necessary and I didn't mean for you to do it. You should probably remove the second commit.

[alesliehughes]

Sorry if I wasn't clear, but that wasn't necessary and I didn't mean for you to do it. You should probably remove the second commit.

All good. I'm new and not sure of the how much to put into a commit yet.

[YuriSizov]

And by removing it I meant removing it, not squashing it. We prefer squashed commits for PRs, but in this case I was asking you to revert your PR to the original change as it was already approved and sufficient.

[alesliehughes]

And by removing it I meant removing it, not squashing it. We prefer squashed commits for PRs, but in this case I was asking you to revert your PR to the original change as it was already approved and sufficient.

Restored back to the original point. Will submitted another PR once this is upstream.

[YuriSizov]

Will submitted another PR once this is upstream.

I don't want to discourage you, but I just wanted to make it clear that that was just my musings. It's not really necessary and you've already fixed the problem itself. Maybe a slightly reworked code could be better for future maintenance, but it's a minor thing, which is why we approved your PR as it was and didn't ask for any changes.

Thanks for humoring me though! If you wish to contribute more, there are many more bugs to tackle in this issue tracker 🙂

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉