Simplify Geometry3D tests #82288
Merged
Simplify Geometry3D tests #82288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these tests was defining a local struct to store the data for each test case, and creating an array of them. In all of the tests there were only a few entries in the array, and in most of the tests the additional complexity of the structs did not provide any scaling or readability benefit even if there were hundreds of test case data entries.
Upon further investigation, these were not given a thorough review when they were first merged. #44974 was only reviewed by one contributor, and then quickly merged the same day.
This PR simplifies the Geometry3D tests, which also brings them closer to our other tests. It also fixes some places where the case convention was not correct (ex:
Vector3 GoodTriangle[3]).