Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ctrl+P as shortcut to quick open files in addition to Shift+Alt+O #81770

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

kevincardona
Copy link
Contributor

@kevincardona kevincardona commented Sep 16, 2023

This also adds ED_SHORTCUT_ARRAY_AND_COMMAND which uses ED_SHORTCUT_ARRAY to allow multiple default command shortcuts.

There's no overlap with any pre-existing commands and will make the transition easier on VS Code users as it's the same shortcut.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rely on Ctrl + P a lot in VS Code, but I rarely ever use Alt + Shift + O as it's an unusual shortcut. Alt + Shift is what I associate with accidentally switching keyboard layouts on Windows 👀

@kevincardona
Copy link
Contributor Author

It looks like the checks failed, i'm not familiar with the nuances of the linux compilation/testing and am not sure if these changes were related to the failure in the linux tests (divide by zero in Node3DEditorViewport::_update_camera). I rebased with master

@akien-mga akien-mga merged commit 8728cac into godotengine:master Sep 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants