Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vector2/3/4i.MAX and MIN #81741

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 16, 2023

@KoBeWi KoBeWi added this to the 4.x milestone Sep 16, 2023
@KoBeWi KoBeWi requested review from a team as code owners September 16, 2023 14:41
@AThousandShips AThousandShips changed the title Add Vector2i.MAX Add Vector2/3/4i.MAX Sep 16, 2023
@AThousandShips
Copy link
Member

AThousandShips commented Sep 16, 2023

Let's add MIN while we're at it, as per this

@kleonc
Copy link
Member

kleonc commented Sep 16, 2023

Let's add MIN while we're at it, as per this

Indeed. In case of float vectors VectorN.INF can be used for both min/max limits respectively (-VectorN.INF for min). In case of integer vectors VectorNi.MIN is not the same as -VectorNi.MAX and hence it makes sense to add both of them.

@KoBeWi KoBeWi force-pushed the vectoring_to_the_MAXXX branch from 8da8110 to 81ed5c2 Compare September 16, 2023 15:43
@KoBeWi KoBeWi force-pushed the vectoring_to_the_MAXXX branch from 81ed5c2 to 406b25f Compare September 16, 2023 17:30
@KoBeWi KoBeWi changed the title Add Vector2/3/4i.MAX Add Vector2/3/4i.MAX and MIN Sep 16, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 16, 2023
@KoBeWi KoBeWi force-pushed the vectoring_to_the_MAXXX branch from 406b25f to a8b614d Compare September 16, 2023 19:17
doc/classes/Vector2i.xml Outdated Show resolved Hide resolved
@KoBeWi KoBeWi force-pushed the vectoring_to_the_MAXXX branch from a8b614d to adc930b Compare September 16, 2023 19:52
@akien-mga akien-mga merged commit 7bb80b1 into godotengine:master Sep 17, 2023
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the vectoring_to_the_MAXXX branch September 17, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Vector2i.MAX as equivalent to Vector2.INF
4 participants