Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing documentation for Skeleton3D methods #81697

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add missing documentation for Skeleton3D methods #81697

merged 1 commit into from
Nov 10, 2023

Conversation

nathanjf
Copy link

Update get/set for pose position/rotation/scale

@nathanjf nathanjf requested a review from a team as a code owner September 15, 2023 15:24
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 15, 2023
@AThousandShips AThousandShips requested a review from a team September 15, 2023 15:45
@YuriSizov YuriSizov removed the request for review from a team November 10, 2023 18:05
@YuriSizov
Add missing documentation for Skeleton3D methods
13e2e4e 
Adds description for get/set pose position/rotation/scale.
YuriSizov
YuriSizov approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I squashed commits and rebased on your behalf, also updated the commit message.

Just FYI the email that you've used to author this commit is not linked to your GitHub account. You may want to fix that.

@YuriSizov YuriSizov changed the title Update get/set for pose position/rotation/scale in Skeleton3D class reference Add missing documentation for Skeleton3D methods Nov 10, 2023
@akien-mga akien-mga merged commit 60e46cf into godotengine:master Nov 10, 2023
15 checks passed
@akien-mga
Copy link
Member

akien-mga commented Nov 10, 2023 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@nathanjf @akien-mga @YuriSizov @smix8 @AThousandShips