Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show alert if .NET assemblies dir does not exist #80212

Conversation

raulsntos
Copy link
Member

Shows a clearer message to users when the data directory is missing.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 3, 2023
@akien-mga akien-mga merged commit 0606ba7 into godotengine:master Aug 3, 2023
14 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/check_api_assemblies_dir_exists branch August 3, 2023 13:46
@RedworkDE
Copy link
Member

AFAIK previously you could run a non-C# project with the dotnet export template and it would work just fine except that it prints that error in the console, while now it will show a message box.
Should this error be conditional to some indicator in the pck that the data dir even should exist or is this case rare enough to not matter?

@akien-mga
Copy link
Member

That's a good point. Ideally it should be possible to export a non-C# project and have it just work. Maybe this could be dependent on the presence of the res://.godot/mono/ folder, or some other metadata that gets set on export?

@raulsntos
Copy link
Member Author

raulsntos commented Aug 3, 2023

We can probably extract the GDMono::should_initialize method from #74089.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants