Initialize MSDF parameters in BaseMaterial3D with default #79983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:rendering
topic:3d
cherrypick:4.1
Calinou
approved these changes
Jul 28, 2023
clayjohn
approved these changes
Jul 28, 2023
|
Looks great! Thank you! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the initialization of MSDF parameters in BaseMaterial3D when using the default values.
The problem seems to be that
msdf_pixel_rangewill not be initialized when loading the material using its default value.The left material is a
StandardMaterial3Dwith a MSDF texture andalbedo_texture_msdfenabled. The right material is the same but converted to aShaderMaterial. When opening the scene, the left texture look blurry. When settingmsdf_pixel_rangeof theStandardMaterial3Dto another value than 4, it looks sharp.I also changed the minimum range value of
msdf_outline_sizeto 0 which is the default according to the documentation.Test project: msdf.zip