Add multi-threaded NavMesh baking to NavigationServer #79972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
navgenerator_multithreading_4.x
branch
3 times, most recently
from
25bb8ab
to
8869c41
Compare
RandomShaper
approved these changes
Aug 1, 2023
Adds multi-threaded NavMesh baking to NavigationServer.
smix8
force-pushed
the
navgenerator_multithreading_4.x
branch
from
8869c41
to
8686e84
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds multi-threaded NavMesh baking to NavigationServer.
Requires #79643 to be merged first.
NavigationServer3DusingWorkerThreadPool.NavigationServer3D.bake_from_source_geometry_data_async()to the API.ThreadfromNavigationRegion3D, it now calls the NavigationServer instead.The threaded navmesh baking is auto-disabled inside the Editor (as it was before) due to random crashes when switching Editor Scenes or Gizmos.
I first did not want to poll the WorkerThreadPool like that to finish tasks and instead use deferred calls to make the thread functions exit themself in a "fire & forget" way. While this worked well it was very unresponsive as deferred calls had to wait for the next message queue flush and missed important navigation map sync points for the current server iteration. It also had problems with unexpected shutdowns so I reverted that to a classic server sync.