Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse bottom panel if there is no active tab #79078

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 5, 2023

Fixes #79022

@KoBeWi KoBeWi added bug topic:editor cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 5, 2023
@KoBeWi KoBeWi added this to the 4.2 milestone Jul 5, 2023
@KoBeWi KoBeWi requested a review from YuriSizov July 5, 2023 21:05
@KoBeWi KoBeWi force-pushed the if_you_gaze_into_the_empty_bottom_panel,_the_empty_bottom_panel_gazes_also_into_you branch from 829ff36 to 59ae7e2 Compare July 5, 2023 21:07
Comment on lines +5296 to +5297
bottom_panel_items[0].control->show(); // _bottom_panel_switch() can collapse only visible tabs.
_bottom_panel_switch(false, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that we should probably implement properly in the future.

@YuriSizov YuriSizov merged commit ef155c1 into godotengine:master Jul 10, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@KoBeWi KoBeWi deleted the if_you_gaze_into_the_empty_bottom_panel,_the_empty_bottom_panel_gazes_also_into_you branch July 10, 2023 14:52
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor starts with glitched bottom panel if closed with temporary editor
2 participants