Clear specular buffer if sky mode is canvas and screen space effects are used #78624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly clear the separate specular buffer when the background mode is canvas and screen space effects (and thus a separate specular buffer) are used.
clayjohn
approved these changes
Jun 23, 2023
|
@clayjohn Should we cherry-pick this to 4.1? |
clayjohn
added
the
cherrypick:4.1
Sure! |
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canvas background mode does not clear the color buffer, but copies over it. If screen-space specular effects are enabled and the background is blank, this would result in ghosting due to the separate specular buffer copy. Need to explicitly clear the specular buffer once we're done with it to fix it.
Closes #76044
(Note, this fixes the artifacting when resizing the window mentioned in that issue, too, but only once resizing is stopped. Previously, the flashing and artifacts would remain after resizing was finished. Now at least it's cleared once the window stops moving. Still, this PR does fix the original issue and logically makes sense. That other bug should probably be a separate issue and PR as the cause seems to be different.)